Skip to content

Conversation

@brokentone
Copy link

Pull Request Name

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
List any dependencies that are required for this change.

Eslint expects a certain structure, of which meta.type is expected: https://eslint.org/docs/latest/extend/custom-rules#rule-structure

This powers the ESLint cli (or node API) functionality to filter by a type of rule when fixing. https://eslint.org/docs/latest/use/command-line-interface#--fix-type When nothing is specified, the rule cannot be selected for at all.

I selected the type of "suggestion" for which the definition is:

The rule is identifying something that could be done in a better way but no errors will occur if the code isn’t changed.

I believe all the rules here, while possibly strong suggestions, are suggestions when read in this manner.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

I ran the supplied tests and they still pass, as well as I made the corollary updates to a project that was showing violations of this rule which were not previous fixable, and now are fixable.

Test Configuration:

  • OS + version: e.g. macOS Sequoia 15.7.1
  • NPM version: 10.8.2
  • Node version: v20.19.5

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant